[wgsl in and IR] naga ray tracing pipelines #8570
Open
+1,814
−74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Initial proposal for the wgsl front-end of #6760
Description
Adds wgsl-in and (partial) validation for the simplest version of ray tracing pipelines. This matches the spirv and hlsl specs to the best of my knowledge (though with less than complete validation). Things may change in the future though. @JMS55 may wish to check the naming ect. I don't normally open a naga PR w/o a full way through, but last time I tried pipelines I did that and struggled to keep it up to date.
Naming differences from vulkan
LaunchId->ray_invocation_id(I think its clearer what it is talking about)LaunchSize->num_ray_invocationsInstanceCustomIndex->instance_custom_data(like ray queries)RayTmax->ray_t_current_max(unlikeRayTmin, it changes over the life cycle of the ray, and doesn't match the field of the ray desc)Testing
Snapshot test from wgsl to IR.
Squash or Rebase?
Squash
Checklist
cargo fmt.taplo format.cargo clippy --tests.cargo xtask testto run tests.CHANGELOG.mdentry.